httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ralf S. Engelschall" <...@engelschall.com>
Subject Re: [PATCH] Support for Mac OS X, some cleanup for Mac OS X Server
Date Fri, 30 Apr 1999 14:36:48 GMT

In article <199904291712.KAA22918@scv1.apple.com> you wrote:

>   I finally got around to building Apache on Mac OS (X, which is not  
> the same OS as Mac OS X Server, go figure) and got the initial work  
> done.  While I was at it, I cleaned up some Mac OS X Server issues.

Sounds all fine for me, except for two things:

>[...]
>  - Added -DAPACI when building with APACI so you can tell in
>    ap_config.h, so instead of "#if 0" around the defaults,
>    I now have "#ifndef APACI", and you can now get the same
>    results without APACI as with.
>[...]

I still don't understand this: IMHO there should be no need for such a define,
because there should be no situation where one has to know this. It's at least
against the intention that APACI and src/Configure are equal in results and
just are different frontends.  Isn't it enough to replace your #define XXX
with #ifndef XXX, #define XXX, #endif as we already do it in httpd.h for those
defines?

>  - Made the default layout on Mac OS X Server be "Mac OS X
>    Server" instead of "Apache".
>[...]
>      *--with-layout=* )
>          ;;
>      * )
> +	case `$aux/GuessOS` in
> +	    *-apple-rhapsody*) default_layout="Mac OS X Server";;
> +	    *-apple-macos*) default_layout="Mac OS X Server";;
> +	    *) default_layout="Apache";;
> +	esac
>          if [ "x$*" = "x" ]; then
> -            set -- '--with-layout=Apache'
> +            set -- "--with-layout=$default_layout"
>          else
> -            set -- '--with-layout=Apache' "$@"
> +            set -- "--with-layout=$default_layout" "$@"

Hmmm... that introduces a platform dependent kludge which makes APACI too
inconsistent and is at least against consistent defaults.  A default is a
default and should be the same for all platforms. Why should a
``--with-layout="Mac OS X Server"'' be the default for Mac OS X when for
instance ``--with-layout=RedHat'' isn't the default for RedHat, etc? No, I've
to vote -1 for this part of the patch. When --with-layout="Mac OS X Server"
reads to ugly for you then perhaps you can at last rename it to
--with-layout="MacOSX"...

The remaining parts of the patch are ok for me, of course.

                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com

Mime
View raw message