httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@devsys.jaguNET.com>
Subject Re: cvs commit: apache-1.3/src CHANGES
Date Wed, 21 Apr 1999 16:54:01 GMT
I still think 

	if [ "x`whoami`" != "xroot" ]

is more portable. 'id' generates a lot of info and it's easy
for the test to be confused. Still, neither does what we want
and check for an actual UID of 0. 'toor' anyone? For that, we'd
need to grab the UID from /etc/passwd

Dean Gaudet wrote:
> 
> OK I see you already use this bogus technique elsewhere.
> 
> Whatever.
> 
> Dean
> 
> On 21 Apr 1999 rse@hyperreal.org wrote:
> 
> > rse         99/04/21 07:28:12
> > 
> >   Modified:    .        Makefile.tmpl
> >                src      CHANGES
> >   Log:
> >   Fix the ownership delegation for proxy directory under `make install'.  This
> >   now uses the same check as APACI's configure but is a install-time decision
> >   and not a configure-time decision (which can be especially important for
> >   package maintainers).
> >   
> >   Revision  Changes    Path
> >   1.73      +6 -2      apache-1.3/Makefile.tmpl
> >   
> >   Index: Makefile.tmpl
> >   ===================================================================
> >   RCS file: /home/cvs/apache-1.3/Makefile.tmpl,v
> >   retrieving revision 1.72
> >   retrieving revision 1.73
> >   diff -u -r1.72 -r1.73
> >   --- Makefile.tmpl	1999/04/21 13:20:46	1.72
> >   +++ Makefile.tmpl	1999/04/21 14:28:01	1.73
> >   @@ -256,8 +256,12 @@
> >    	$(MKDIR) $(root)$(runtimedir)
> >    	$(MKDIR) $(root)$(logfiledir)
> >    	$(MKDIR) $(root)$(proxycachedir)
> >   -	-chown $(conf_user) $(root)$(proxycachedir)
> >   -	-chgrp $(conf_group) $(root)$(proxycachedir)
> >   +	-@if [ ".`id | grep root`" != . ]; then \
> >   +		echo "chown $(conf_user) $(root)$(proxycachedir)"; \
> >   +		chown $(conf_user) $(root)$(proxycachedir); \
> >   +		echo "chgrp $(conf_group) $(root)$(proxycachedir)"; \
> >   +		chgrp $(conf_group) $(root)$(proxycachedir); \
> >   +	fi
> >    	@echo "<=== [mktree]"
> >    
> >    #   install the server program and optionally corresponding
> >   
> >   
> >   
> >   1.1322    +3 -0      apache-1.3/src/CHANGES
> >   
> >   Index: CHANGES
> >   ===================================================================
> >   RCS file: /home/cvs/apache-1.3/src/CHANGES,v
> >   retrieving revision 1.1321
> >   retrieving revision 1.1322
> >   diff -u -r1.1321 -r1.1322
> >   --- CHANGES	1999/04/21 13:20:47	1.1321
> >   +++ CHANGES	1999/04/21 14:28:08	1.1322
> >   @@ -1,5 +1,8 @@
> >    Changes with Apache 1.3.7
> >    
> >   +  *) Fix the ownership delegation for proxy directory under `make install'.
> >   +     [Ralf S. Engelschall]
> >   +
> >      *) APACI would not correctly build suexec. [Maria Verina
> >         <mariav@icgeb.trieste.it>] PR#4260
> >    
> >   
> >   
> >   
> > 
> 
> 


-- 
===========================================================================
   Jim Jagielski   |||   jim@jaguNET.com   |||   http://www.jaguNET.com/
            "That's no ordinary rabbit... that's the most foul,
            cruel and bad-tempered rodent you ever laid eyes on"

Mime
View raw message