httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@devsys.jaguNET.com>
Subject Re: [PATCH] add Expat as an option
Date Thu, 15 Apr 1999 19:40:57 GMT
> 
> For the Expat inclusion to work, it is also presumed that Expat's
> "xmlparse.h" header is dropped into src/include/.
> => Q: should Configure also ensure that the xmlparse.h header exists? I
> say "no" with the expectation that the person add/removing Expat to/from
> the distribution should know better.

I think that we should either adjust -I as required or use the
same magic as with HSregex, ie:
    #ifdef WIN32
    #include "../include/hsregex.h"
    #elif defined(USE_HSREGEX)
    #include "hsregex.h"
    #else
    #include <regex.h>
    #endif

Course, this would require renaming of xmlparse.h

> 
> Note: this patch uses the same style of Makefile symbols and stuff as
> the HSREGEX stuff. (the header in src/include/ and the $(REGLIB) stuff.
> It may be interesting in the future to provide a more extensible way to
> do this, so we don't end up with a bazillion *LIB things in the link
> lines.

Yeah. Something like what's done with MODULES would be cool.

> 
> => Q: what should we do if a module says RULE_EXPAT=yes, but the
> directory doesn't exist? This test would be at line 1552 (of the patched
> Configure); what is the "approved" way to punt from Configure with an
> error?

I vote that we include the EXPAT directory :) We then allow
for people to include it or not, ala hsregex.

> 
> Presuming this goes in, then I'll follow up with an appropriate
> src/expat/ subdirectory patch. That's a bit different decision: do we do
> nothing in the core for Expat, do we add a framework but not ship Expat
> itself, or do we add the framework and Expat?

+1 on both.

This looks like a good start!
-- 
===========================================================================
   Jim Jagielski   |||   jim@jaguNET.com   |||   http://www.jaguNET.com/
            "That's no ordinary rabbit... that's the most foul,
            cruel and bad-tempered rodent you ever laid eyes on"

Mime
View raw message