httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <>
Subject Re: [PATCH] add Expat as an option
Date Thu, 15 Apr 1999 13:48:17 GMT
I like the idea of adding an XML to the base, because more and more
add-on products will require it (maybe even the base will
eventually). Just like in the regex case, there should be an option
to use the bundled (or installed in the provided space) library, or
a different available library.

As the number of "plug-in libraries" like these increases, it might
be desirable to add a library-specific configuration script (as in
the module configuration case, where it can either be imbedded in
the source or provided as a separate *.module file), rather than
hard-coding each test into Configure.

> Presuming this goes in, then I'll follow up with an appropriate
> src/expat/ subdirectory patch. That's a bit different decision: do we do
> nothing in the core for Expat, do we add a framework but not ship Expat
> itself, or do we add the framework and Expat?

I'd opt for #2: add a framework but not ship Expat


> Index: Configure
> ===================================================================
> RCS file: /home/cvs/apache-1.3/src/Configure,v
> retrieving revision 1.337
> diff -u -u -r1.337 Configure
> --- Configure	1999/03/30 08:58:33	1.337
> +++ Configure	1999/04/15 09:59:57
> -MAKEDIRS="support main ap regex $OSDIR"
> +MAKEDIRS="support $SUBDIRS"

Am I correct in my assumption that "expat" is now (if the directory
was found) part of $MAKEDIRS, but neither "regex" nor "$OSDIR" are?

Otherwise, this looks like a very good start.

<Martin.Kraemer@MchP.Siemens.De>      |        Siemens Information and
Phone: +49-89-636-46021               |        Communication  Products
FAX:   +49-89-636-47816               |        81730  Munich,  Germany

View raw message