Return-Path: Delivered-To: new-httpd-archive@hyperreal.org Received: (qmail 23313 invoked by uid 6000); 20 Mar 1999 23:16:51 -0000 Received: (qmail 23296 invoked from network); 20 Mar 1999 23:16:49 -0000 Received: from kurgan.lyra.org (root@208.192.43.9) by taz.hyperreal.org with SMTP; 20 Mar 1999 23:16:49 -0000 Received: from kurgan.lyra.org (localhost [127.0.0.1]) by kurgan.lyra.org (8.8.5/8.8.5) with SMTP id PAA21014; Sat, 20 Mar 1999 15:12:05 -0800 Message-ID: <36F42B45.3D997BBB@lyra.org> Date: Sat, 20 Mar 1999 15:12:05 -0800 From: Greg Stein X-Mailer: Mozilla 3.01 (X11; I; Linux 2.0.28 i586) MIME-Version: 1.0 To: Cliff Skolnick , new-httpd@apache.org CC: Lars Eilebrecht Subject: Re: [patch] mod_access/3821 References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org Will this still allow somebody to use Limit and LimitExcept to allow an M_INVALID operation against that directory or its contents? For example, there are some additional DAV operations that Apache classifies as M_INVALID, but I still need to interpret. There would be no way to do that if mod_access unconditionally punted all M_INVALID operations. thx -g Cliff Skolnick wrote: > > Here's a quick patch that will tag all M_INVALID check_dir_access calls > as FORBIDDEN. > > Cliff > > Index: apache-1.3/src/modules/standard/mod_access.c > =================================================================== > RCS file: /home/cvs/apache-1.3/src/modules/standard/mod_access.c,v > retrieving revision 1.38 > diff -u -r1.38 mod_access.c > --- mod_access.c 1999/01/01 19:05:06 1.38 > +++ mod_access.c 1999/03/20 22:28:00 > @@ -353,7 +353,10 @@ > ap_get_module_config(r->per_dir_config, &access_module); > int ret = OK; > > - if (a->order[method] == ALLOW_THEN_DENY) { > + if (method >= METHODS) { > + ret = FORBIDDEN; > + } > + else if (a->order[method] == ALLOW_THEN_DENY) { > ret = FORBIDDEN; > if (find_allowdeny(r, a->allows, method)) > ret = OK; > > -- > Cliff Skolnick > Steam Tunnel Operations > cliff@steam.com > http://www.steam.com/ -- Greg Stein, http://www.lyra.org/