httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Bley <j...@acpub.duke.edu>
Subject [PATCH] module init doesn't seem to be called in mod_so.c
Date Tue, 02 Mar 1999 09:38:18 GMT
I was using cflow to try to comprehend some aspects of Apache (as well as 
look for dead code) and noticed that ap_single_module_init wasn't being 
called by anything.
The comment in http_config.h says
    /* init() occurs after config parsing, but before any children are
     * forked.
So I figured, perhaps mod_so *should* call that, since it calls 
ap_single_module_configure at the appropriate place.

Or maybe I have it all wrong... I'm still learning.
-- 
John Bley - jbb6@acpub.duke.edu
Duke '99 - English/Computer Science
  Since English is a mess, it maps well onto the problem space,
  which is also a mess, which we call reality.     - Larry Wall

--- mod_so.c.orig	Tue Mar  2 04:23:19 1999
+++ mod_so.c	Tue Mar  2 04:24:31 1999
@@ -280,6 +280,7 @@ static const char *load_module(cmd_parms
      * Finally we need to run the configuration process for the module
      */
     ap_single_module_configure(cmd->pool, cmd->server, modp);
+    ap_single_module_init(cmd->pool, cmd->server, modp);
 
     return NULL;
 }

Mime
View raw message