httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] module init doesn't seem to be called in mod_so.c
Date Tue, 09 Mar 1999 20:07:53 GMT
Sometimes there are functions which we don't use in apache, but which are
useful for third party folks.  In those cases it's better to leave them as
dead code.

This probably isn't one of those cases.  I'm just trying to forestall a
jihad against "dead code".

Dean

On Sun, 7 Mar 1999, John Bley wrote:

> On Sun, 7 Mar 1999, Ben Laurie wrote:
> > Ralf S. Engelschall wrote:
> > > No, it shouldn't removed, because it's a correct function.
> > > Just it's use is currently not reasonable.
> > 
> > I think that's a pretty weird attitude...
> 
> I agree.  It's dead code.  Dead code means larger binary for no reason 
> whatsoever.  Only a few hundred bytes in this case, but still... 
> 
> If there *are* plans to use it in the immediate future, perhaps it could be 
> #if 0'ed or commented out for now?  (Preferably with a TTL to avoid 
> future lava flow.)
> 
> [For those joining the party late, "it" is ap_single_module_init()]
> 
> -- 
> John Bley - jbb6@acpub.duke.edu
> Duke '99 - English/Computer Science
>   Since English is a mess, it maps well onto the problem space,
>   which is also a mess, which we call reality.     - Larry Wall
> 
> 


Mime
View raw message