httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] Many, many nits in modules
Date Mon, 01 Mar 1999 15:36:28 GMT


On Wed, 24 Feb 1999, John Bley wrote:

> Consider part of the patch:
> -	NULL
> +	NULL, NULL, NULL, OR_NONE, NO_ARGS, NULL
> 
> NO_ARGS doesn't have an underlying representation of 0: it's the 7th 
> element of enum cmd_how.  It's fairly unlikely, but if somebody decides 
> to accept command_structs with NULL names and sees that this (last) one 
> accepts "RAW_ARGS" (the first member of the enum), that code could break.

If anything reads that field after noticing the first field is NULL it's
broken.  I'll accept a patch fixing such broken code. 

> Or, consider that cut-n-paste coding in mod_so.c led to this:
>     NULL,			/* type_checker */
> +   NULL,			/* fixer_upper */
>     NULL,			/* logger */
> It's fairly unlikely that somebody would have wanted to go in and set up 
> a proper "logger" pointer, but if they had, it would have been registered as
> the fixer_upper pointer instead.  Ouch, what a debugging headache.  "My 
> method's not even being called!"

That one is documentation, committing it. 

Dean



Mime
View raw message