httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Bloom <...@raleigh.ibm.com>
Subject Re: cvs commit: apache-apr/apr/test Makefile.beos testfile.c
Date Mon, 01 Mar 1999 15:00:10 GMT

You're right.  My mistake.  I was rushing through the code, and expecting
the compiler to catch any of those annyinh syntax errors.  In this case,
the compiler missed it, nd because the code always worked, I never gave it
a second thought.  I'll fix it later.

Ryan

On Mon, 1 Mar 1999, Martin Kraemer wrote:

> I don't see a reason why ANY platform should use the #else
> clause, as lseek() is defined as
> 
>      off_t lseek (int fildes, off_t offset, int whence);
> 
> and the #else branch is simply in error (albeit tolerable when
> the compiler silently translates (int)SEEK_SET into (off_t)0L
> and vice versa).
> 
> IMO, the old error should simply be fixed, not #ifdef'ed.
> 
>     Martin
> 
> >   Index: testfile.c
> >   ===================================================================
> >   RCS file: /home/cvs/apache-apr/apr/test/testfile.c,v
> >   retrieving revision 1.3
> >   retrieving revision 1.4
> >   diff -u -r1.3 -r1.4
> >   --- testfile.c	1999/02/25 19:48:57	1.3
> >   +++ testfile.c	1999/02/26 18:58:59	1.4
> >   @@ -109,8 +112,11 @@
> >        }
> >    
> >        fprintf(stdout, "Moving to start of file.......");
> >   -
> >   +#ifdef BEOS
> >   +    if (lseek(thefile->filedes, 0, SEEK_SET) != 0) {
> >   +#else
> >        if (lseek(thefile->filedes, SEEK_SET, 0) != 0) {
> >   +#endif
> -- 
> <Martin.Kraemer@MchP.Siemens.De>      |        Siemens Information and
> Phone: +49-89-636-46021               |        Communication  Products
> FAX:   +49-89-636-47816               |        81730  Munich,  Germany
> 

_______________________________________________________________________
Ryan Bloom		rbb@raleigh.ibm.com
4205 S Miami Blvd	
RTP, NC 27709		It's a beautiful sight to see good dancers 
			doing simple steps.  It's a painful sight to
			see beginners doing complicated patterns.	


Mime
View raw message