Return-Path: Delivered-To: new-httpd-archive@hyperreal.org Received: (qmail 225 invoked by uid 6000); 19 Feb 1999 22:46:49 -0000 Received: (qmail 213 invoked from network); 19 Feb 1999 22:46:47 -0000 Received: from twinlark.arctic.org (204.107.140.52) by taz.hyperreal.org with SMTP; 19 Feb 1999 22:46:47 -0000 Received: (qmail 9217 invoked by uid 500); 19 Feb 1999 22:46:30 -0000 Date: Fri, 19 Feb 1999 14:46:30 -0800 (PST) From: Dean Gaudet To: new-httpd@apache.org Subject: Re: cvs commit: apache-1.3/src/modules/standard mod_log_config.c In-Reply-To: <19990217232821.21583.qmail@hyperreal.org> Message-ID: X-Comment: Visit http://www.arctic.org/~dgaudet/legal for information regarding copyright and disclaimer. MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org On 17 Feb 1999 coar@hyperreal.org wrote: > Add conditional logging based upon environment variable existence. > Also add RefererIgnore functionality from mod_log_referer to > mod_log_config; mod_log_referer and mod_log_agent are now > deprecated. The list of envariables to check is set up as > an array even though the current implementation (TAKE23) > only handles one; just in case we ever want to do something > strange like, 'env=foo,bar,!bag'. I don't recall there being a general consensus on deprecating mod_log_agent and mod_log_referer. I seem to recall there being at least two of us that didn't see the point of putting RefererIgnore into mod_log_config, because the env control solves it just fine. I don't see the point of an array that only ever has one element -- if we need multiple environment variables in the future we can get the code from archives. I don't see the point of the "int conditions" when it's the same as saying "condition_list != NULL". I thought all these concerns were voiced when you posted the earlier patch for comments. -1. Dean