Return-Path: Delivered-To: new-httpd-archive@hyperreal.org Received: (qmail 12577 invoked by uid 6000); 9 Feb 1999 18:11:32 -0000 Received: (qmail 12561 invoked from network); 9 Feb 1999 18:11:28 -0000 Received: from twinlark.arctic.org (204.107.140.52) by taz.hyperreal.org with SMTP; 9 Feb 1999 18:11:28 -0000 Received: (qmail 20819 invoked by uid 500); 9 Feb 1999 18:11:11 -0000 Date: Tue, 9 Feb 1999 10:11:11 -0800 (PST) From: Dean Gaudet To: new-httpd@apache.org Subject: Re: cvs commit: apache-1.3/src/support httpd.exp In-Reply-To: <19990209165727.8821.qmail@hyperreal.org> Message-ID: X-Comment: Visit http://www.arctic.org/~dgaudet/legal for information regarding copyright and disclaimer. MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org On 9 Feb 1999 fielding@hyperreal.org wrote: > - /* Check the If-Range header for Etag or Date */ > - > + /* Check the If-Range header for Etag or Date. > + * Note that this check will return false (as required) if either > + * of the two etags are weak. > + */ > if ((if_range = ap_table_get(r->headers_in, "If-Range"))) { > if (if_range[0] == '"') { > if (!(match = ap_table_get(r->headers_out, "Etag")) || > - (strcasecmp(if_range, match) != 0)) > + (strcmp(if_range, match) != 0)) > return 0; > } But if both are weak it will do a range request, and that's incorrect. Sure, the client shouldn't be issuing an If-Range with a weak tag, but... Also, regarding ap_*_list_item and comments, section 2.2 of http/1.1 rev-06 says: Comments can be included in some HTTP header fields by surrounding the comment text with parentheses. Comments are only allowed in fields containing "comment" as part of their field value definition. In all other fields, parentheses are considered part of the field value. I only see "comment" as part of the field value definition for Server, User-Agent, and Via. So I don't think it's correct to be skipping "comments" in If-Match, If-None-Match, ... Dean