httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] Re: ugly problem with sub-requests
Date Thu, 25 Feb 1999 18:09:13 GMT


On Thu, 25 Feb 1999, Greg Stein wrote:

> > +     /* ### would be nice to pass "method" to ap_set_sub_rqe_protocol */
> > +     rnew->method = method;
> > +     rnew->method_number = ap_method_number_of(method);
> > +
> 
> Right here.  rnew->method is "char *", while the argument is "const char
> *". The compiler complains about dropping the "const".
> 
> I'm not sure whether to argue for a change to the request_rec structure,
> or to bite down and do an ap_pstrdup().

Change it to const char *method in the request_rec ... there's at least
one place where it's set to a ""-quoted string, so anyone mucking with it
is potentially doing harm.

(I wonder how much noise -Wwrite-strings gives these days...) 

Dean



Mime
View raw message