httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rodent of Unusual Size <Ken.C...@Golux.Com>
Subject Re: [PATCH] Merge RefererIgnore into mod_log_config
Date Wed, 10 Feb 1999 23:15:41 GMT
Dean Gaudet wrote:
> 
> No my opinion hasn't changed, I have outstanding complaints with adding
> unneeded functionality to mod_log_config.  Piped logs solve this and all
> the other dozens of logging requests that keep recurring just fine.

And my opinion hasn't changed either.. :-) Piped logs are great for
this IFF you don't mind having another process hanging around just
to parse and throw away the stuff your server spent resources logging
unnecessarily.  For log splitting and transformations I agree 100%;
for log/don't log decisions, I think the server is the correct place.

> On Wed, 10 Feb 1999, Rodent of Unusual Size wrote:
> 
> > +    int ignore_referers;
> > +    array_header *referer_list;
> 
> You could test referer_list->nelts rather than keeping a separate
> ignore_referers member.

True.  I was thinking of memory, in terms of not creating the
array unnecessarily.  At potentially one array per server,
it's probably a wash.  With 500 vhosts, it's 500*sizeof(int)
versus 500*sizeof(array_header)+2000*sizeof(char *) total, plus
pointer fetching to check the field.  NBD.

> > +    {"RefererIgnore", add_referer_ignore, NULL, RSRC_CONF, ITERATE,
> > +     "referer URLs to ignore"},
> 
> Assuming that nobody is going to listen to my advocation of KISS I'd much
> rather see you test for the presence of a note or environment variable.
> There's no need to implement "RefererIgnore" and "RefererIgnoreMatch",
> mod_rewrite can set env variables just fine.

I think part of the issue is that not everyone agrees that your
answer is so S. :-)

As for RefererIgnore.. one of the points here is to get *rid* of
mod_log_referer.  Which means making its exact functionality
available elsewhere.  (These were the arguments that kept it
from being removed before.)  But I'd prefer the flexibility of
envariables myself.  So scratch the RefererIgnoreMatch idea,
but I'll leave the RefererIgnore in as is; mod_rewrite is a
lot of bloat if this is the only reason you want it.  (Again,
it's a wash if you're already using mod_rewrite.)
-- 
#ken    P-)}

Ken Coar                    <http://Web.Golux.Com/coar/>
Apache Group member         <http://www.apache.org/>
"Apache Server for Dummies" <http://Web.Golux.Com/coar/ASFD/>

Mime
View raw message