httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Hyde <bh...@pobox.com>
Subject Re: APR Error Protocol - take 2.
Date Mon, 01 Feb 1999 20:42:37 GMT
Rodent of Unusual Size writes:
>I personally consider errno to be evil, almost entirely
>because of the locality and reentrancy issues.  

In this case new is now more evil.

>And someone
>(Lars?  Martin?) commented on the APR draft not mentioning
>pools.

Some of alloc.c (maybe all of it) belongs very low down in APR.

>These two may actually be related. ...
>The context structure  ...
>I think that's enough to start discussion..

I'm not particularly afraid of a few well chosen globals:
    
    typedef struct process_state_s {
        ap_pool *global_pool;
        ap_pool *configuration_pool;
        ...
      } process_state;
    
    typedef struct thread_state_s {
        process_state *process
        ap_pool *thread_pool;
        ...
      } thread_state;
    
    extern thread_state APACHE_TLS *current_thread;
    
But today I can't see any particular advantage to moving errno
into thread_state.

   - ben

Mime
View raw message