httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: apache-api/3657: apache returning status 304 on images that are updated
Date Thu, 21 Jan 1999 00:48:43 GMT
On Wed, 20 Jan 1999, Rodent of Unusual Size wrote:

> Phil Dietz wrote:
> > 
> > After snooping with a proxy and later apache source code,
> > it appears the ap_find_token() command is not working correctly.
> > 
> > Internet Explorer 4.1 and 5.0beta browser sends:
> >                 If-None-Match: W/"2f30-f20-369bbd06"
> > apache returns  Etag: W/"2f30-11b3-369bd28d"
> > 
> > The two are completely different which jives since the image was updated.
> 
> Hmm.  Indeed, the problem appears to be due to '/' being
> considered special for HTTP transforms; in this case,
> specifically by ap_find_token().
> 
> It looks like possible solutions include:
> 
> 1. Change '/' to not be special for HTTP (change
>    gen_test_chars.c).
> 2. Change the weak etag prefix from 'W/' to something else.
> 3. Use some other method than ap_find_token() to locate
>    tokens for comparison.
> 
> [2] is right out - 'W/' is part of the HTTP spec.
> [3] isn't terrific, since it appears that ap_find_token()
> was created for this express purpose (the only place it's
> used is in http_protocol.c).  So [1] looks like the
> easiest solution -- except it depends upon whether
> '/' can ever appear inside a token string.  Looking
> at the spec, it appears that this is the correct
> solution, but I'll defer to Roy.
> 
> Roy?

This is essentially the same bug I was reporting in PR#2065 -- we don't do
proper HTTP parsing at all.  We do something that "almost works".  We
should do something that works. 

Dean


Mime
View raw message