httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Havard" <>
Subject Re: Problem with <Directory proxy:*> and ap_os_canonical_filename()
Date Sun, 31 Jan 1999 03:04:07 GMT
On Tue, 26 Jan 1999 18:33:09 -0800 (PST), Marc Slemko wrote:


>Yuck.  Yet another legacy of people designing code with the idea that
>asserts are a good idea, therefore not creating any way to return errors
>when they first design it.  
>I don't know what DosQueryPathInfo does, but, in general, the general way
>the canonical calls work now is that they do not depend on the thing being
>an actual pathname on that system, but simply convert things that are
>variants on the same valid pathname to that pathname.

DosQueryPathInfo(), the way it's used in ap_ocf (using the FIL_QUERYFULLNAME
flag), doesn't check there's an actual file, it just turns a relative path
into an absolute one.

I'm now starting to think that the correct behaviour in the case of an
invalid name is to just return it unchanged. If it's actually used to try to
open a file later it will fail at that point.

 |  Brian Havard                 |  "He is not the messiah!                   |
 |  |  He's a very naughty boy!" - Life of Brian |

View raw message