httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sam Rasins <sa...@dns.omniport.net>
Subject Re: minor patch for Configure
Date Sat, 02 Jan 1999 16:02:26 GMT
> Jim Jagielski wrote:
>
> Ralf S. Engelschall wrote:
> > 
> > 
> > Hmmm... sorry to say this, but Makefile.config is not really correct, I think.
> > And actually we additionally should look for ^EXTRA_, because out-commented
> > EXTRA_ lines can exists. So, wouldn't be this better ($file is Configuration
> > or the file given via -file):
> > 
> > Index: Configure
> > ===================================================================
> > RCS file: /e/apache/REPOS/apache-1.3/src/Configure,v
> > retrieving revision 1.317
> > diff -u -r1.317 Configure
> > --- Configure   1999/01/01 23:48:01     1.317
> > +++ Configure   1999/01/02 14:17:44
> > @@ -1334,7 +1334,7 @@
> >      CFLAGS="$CFLAGS -DSOCKS -DSOCKS4"
> >      CFLAGS="$CFLAGS -Dconnect=Rconnect -Dselect=Rselect"
> >      CFLAGS="$CFLAGS -Dgethostbyname=Rgethostbyname"
> > -    if [ "x`grep EXTRA_ Makefile | grep lsocks`" = "x" ]; then
> > +    if [ "x`grep '^EXTRA_' $file | grep lsocks`" = "x" ]; then
> >         LIBS="$LIBS -L/usr/local/lib -lsocks"
> >      fi
> >      case $PLAT in
> > @@ -1353,7 +1353,7 @@
> >      CFLAGS="$CFLAGS -DSOCKS -DSOCKS5"
> >      CFLAGS="$CFLAGS -Dconnect=SOCKSconnect -Dselect=SOCKSselect"
> >      CFLAGS="$CFLAGS -Dgethostbyname=SOCKSgethostbyname -Dclose=SOCKSclose"
> > -    if [ "x`grep EXTRA_ Makefile | grep lsocks5`" = "x" ]; then
> > +    if [ "x`grep '^EXTRA_' $file | grep lsocks5`" = "x" ]; then
> >         LIBS="$LIBS -L/usr/local/lib -lsocks5"
> >      fi
>
> I'm not sure about that. At this point in time, Makefile.config does contain
> the "filtered" assignments already, including the EXTRA_* stuff. Searching
> for '^EXTRA_' is right though.
>

What about leading whitespace?

Sambo  P-)
<Sambo@Caribe-Enterprises.com>

Mime
View raw message