httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <martin.krae...@mch.sni.de>
Subject Re: [PATCH] BasicAuth support for Apache Bench (ap)
Date Fri, 01 Jan 1999 21:32:16 GMT
This doesn't check for overflows [ Is (4/3 * strlen(optarg)) greater
than sizeof userpass?] and doesn't work for EBCDIC unless a wrapper
macro ASC(ch) is used. The triple %s%s%s and triple ternary test
could be avoided if you collect "Authorization: Basic "
and the result of base64_encode() plus the trailing "\r\n" all
into the userpass buffer.

But +1 on concept.
    Martin
-- 
<Martin.Kraemer@Mch.SNI.De>      |        Siemens Information and
Phone: +49-89-636-46021          |        Communication  Products
FAX:   +49-89-636-47816          |        81730  Munich,  Germany

Mime
View raw message