Return-Path: Delivered-To: new-httpd-archive@hyperreal.org Received: (qmail 14169 invoked by uid 6000); 30 Dec 1998 11:24:51 -0000 Received: (qmail 14162 invoked from network); 30 Dec 1998 11:24:49 -0000 Received: from thoth.mch.sni.de (192.35.17.2) by taz.hyperreal.org with SMTP; 30 Dec 1998 11:24:49 -0000 X-Envelope-Sender-Is: martin.kraemer@mch.sni.de (at relayer thoth.mch.sni.de) Received: from horus.mch.sni.de (horus.mch.sni.de [139.25.208.11]) by thoth.mch.sni.de (8.9.1a/8.9.1) with ESMTP id MAA03453 for ; Wed, 30 Dec 1998 12:24:47 +0100 (MET) Received: from deejai.mch.sni.de (deejai.mch.sni.de [139.25.105.242]) by horus.mch.sni.de (8.9.1a/8.9.1) with ESMTP id MAA18286 for ; Wed, 30 Dec 1998 12:24:46 +0100 (MET) Received: (from martin@localhost) by deejai.mch.sni.de (8.8.7/8.8.7(UNIX)) id MAA01749 for new-httpd@apache.org; Wed, 30 Dec 1998 12:24:44 +0100 (MET) Message-ID: <19981230122442.A1596@deejai.mch.sni.de> Date: Wed, 30 Dec 1998 12:24:42 +0100 From: Martin Kraemer To: new-httpd@apache.org Subject: Re: [PATCH] Default ordering for FancyIndexed directories References: <368917BF.8D04D153@Apache.Org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.93.2i In-Reply-To: <368917BF.8D04D153@Apache.Org>; from Rodent of Unusual Size on Tue, Dec 29, 1998 at 12:56:15PM -0500 X-Operating-System: SINIX-D 5.41 C1001 X-Organization: Siemens AG (Muenchen, W.Germany) X-Phone: +49-89-636-46021 X-Disclaimer: THE COMMENTS CONTAINED IN THIS MESSAGE REFLECT THE VIEWS OF THE WRITER AND ARE NOT NECESSARILY THE VIEWS OF SIEMENS AG X-No-Junk-Mail: I do not want to get *any* junk mail. Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org > +{ > + char temp[4] = {'x', '=', 'x', '\0'}; While I'm +1 on concept for this new directive (one of my clients already asked for it), this initialisation isn't accepted by some of the compilers I have at hand here. Can it be changed to either char *temp = "?=?", or initialized in code (ap_cpystrn(temp,"?=?", sizeof temp)), or to a static array (threads beware!)? Sorry for being so conservative ;-) > + if (d_cfg->default_order == NULL) { > + d_cfg->default_order = ap_palloc(cmd->pool, 5); > + d_cfg->default_order[4] = '\0'; > + } Why 5? temp[] is only 4 bytes (including nil)! > + strcpy(d_cfg->default_order, temp); > + return NULL; > +} You probably avoided ap_cpystrn() because the size is known beforehand. Nevertheless.... The rest looks good. And a happy new year to everyone! Martin -- | Siemens Information and Phone: +49-89-636-46021 | Communication Products FAX: +49-89-636-47816 | 81730 Munich, Germany