httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ralf S. Engelschall" <...@engelschall.com>
Subject Re: cvs commit: apache-1.3 STATUS
Date Thu, 31 Dec 1998 15:35:58 GMT

In article <199812311400.JAA29655@devsys.jaguNET.com> you wrote:
> Ralf S. Engelschall wrote:
>> 
>> In article <19981231011055.28229.qmail@hyperreal.org> you wrote:
>> > jim         98/12/30 17:10:55
>> 
>> >   Index: STATUS
>> >   ===================================================================
>> >   RCS file: /export/home/cvs/apache-1.3/STATUS,v
>> >   retrieving revision 1.577
>> >   retrieving revision 1.578
>> >   diff -u -r1.577 -r1.578
>> >   --- STATUS   1998/12/31 00:44:12 1.577
>> >   +++ STATUS   1998/12/31 01:10:54 1.578
>> >   @@ -1,5 +1,5 @@
>> >      1.3 STATUS:
>> >   -  Last modified at [$Date: 1998/12/31 00:44:12 $]
>> >   +  Last modified at [$Date: 1998/12/31 01:10:54 $]
>> >    
>> >    Release:
>> >    
>> >   @@ -23,6 +23,8 @@
>> >        * Version component misbehaviour
>> >            See: <36738822.D2FD6C0@lyra.org>
>> >            Status: Ralf mentioned that he knows a solution... (?)
>> >   +    Is this the module placing it's token first? If so, I have
>> >   +    a patch: Jim
>> 
>> Yes it is! My patch would be to remove the additional init call in mod_so,
>> because this breaks backward compatibilies to DSO-aware modules.  What is your
>> patch, Jim?
>> 

> Basically it's (in pseudo diff):

> + ap_set_version();
>         /* Yes this is called twice. */
>   ap_init_modules(pconf, server_conf);
> + version_locked++;
>   ap_open_logs(server_conf, pconf);
>   ap_init_modules(pconf, server_conf);
>   set_group_privs();

Yes, this solves the version problem. And we should do this independent of my
patch. But nevertheless I'm now convinced that the double-init under DSO
situation is not what we should do.  Especially because of backward
compatibility. For instance it totally breaks mod_ssl and similar modules who
carefully have to count the init rounds.

                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com

Mime
View raw message