httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ralf S. Engelschall" <...@engelschall.com>
Subject Re: [PATCH] escape_uri() -> ap_escape_uri()
Date Fri, 18 Dec 1998 15:50:27 GMT

In article <367A6146.F94FA87D@raleigh.ibm.com> you wrote:
> Ralf S. Engelschall wrote:
>>
>>  #ifndef MODULE_MAGIC_NUMBER_MAJOR
>>  #define MODULE_MAGIC_NUMBER_MAJOR 19981211
>>  #endif
>> -#define MODULE_MAGIC_NUMBER_MINOR 0                     /* 0...n */
>> +#define MODULE_MAGIC_NUMBER_MINOR 1                     /* 0...n */
>>  #define MODULE_MAGIC_NUMBER MODULE_MAGIC_NUMBER_MAJOR  /* backward compat */

> Shouldn't you bump MODULE_MAGIC_NUMBER_MAJOR since this will break
> backward compatability? 

Don't know, the whole two number thing confused me.  At least the comment in
ap_mmn.h speaks about binary compatibility. And this isn't of this type, so
I've bumped only the minor number.  Perhaps I'm wrong here because I still
don't understand the real intent behind the two number approach. What is
correct friends?

> You could always leave the escape_uri() macro
> and add ap_escape_uri(). Bleh.

Oh, yes, I forgot the patch from ap_compat.h.  There the escape_uri() macro
will be added.  That's the same way we did it for the other macros on
renaming.
                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com

Mime
View raw message