Return-Path: Delivered-To: new-httpd-archive@hyperreal.org Received: (qmail 18807 invoked by uid 6000); 6 Nov 1998 15:58:33 -0000 Received: (qmail 18795 invoked from network); 6 Nov 1998 15:58:32 -0000 Received: from twinlark.arctic.org (204.62.130.91) by taz.hyperreal.org with SMTP; 6 Nov 1998 15:58:32 -0000 Received: (qmail 9306 invoked by uid 500); 6 Nov 1998 15:58:36 -0000 Date: Fri, 6 Nov 1998 07:58:36 -0800 (PST) From: Dean Gaudet To: new-httpd@apache.org Subject: Re: cvs commit: apache-1.3/src/main alloc.c In-Reply-To: <19981106122438.23614.qmail@hyperreal.org> Message-ID: X-Comment: Visit http://www.arctic.org/~dgaudet/legal for information regarding copyright and disclaimer. MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org On 6 Nov 1998 rse@hyperreal.org wrote: > Fix internal handling of registered cleanups in alloc.c by making sure that > NULL-specified callback functions (we don't do this in the official set of > modules, but third-party modules do) for ap_register_cleanup() always mean the > dummy ap_null_cleanup() so we don't dump core later when running the cleanups. If third party modules do this, they are broken. The API requires the parameters to be non-null. This is not a new feature of 1.3, it's even there in the 1.2 code, it's been there forever. There's essentially no reason we should expend the extra comparison and branch in the code just to accomodate this. Dean