Return-Path: Delivered-To: new-httpd-archive@hyperreal.org Received: (qmail 496 invoked by uid 6000); 8 Nov 1998 19:10:44 -0000 Received: (qmail 489 invoked from network); 8 Nov 1998 19:10:43 -0000 Received: from thoth.mch.sni.de (192.35.17.2) by taz.hyperreal.org with SMTP; 8 Nov 1998 19:10:43 -0000 X-Envelope-Sender-Is: martin.kraemer@mch.sni.de (at relayer thoth.mch.sni.de) Received: from deejai.mch.sni.de (deejai.mch.sni.de [139.25.105.242]) by thoth.mch.sni.de (8.9.1a/8.9.1) with ESMTP id UAA29290 for ; Sun, 8 Nov 1998 20:10:42 +0100 (MET) Received: (from martin@localhost) by deejai.mch.sni.de (8.8.7/8.8.7(UNIX)) id UAA09483 for new-httpd@apache.org; Sun, 8 Nov 1998 20:10:41 +0100 (MET) Message-ID: <19981108201039.B9169@deejai.mch.sni.de> Date: Sun, 8 Nov 1998 20:10:39 +0100 From: Martin Kraemer To: new-httpd@apache.org Subject: Re: [PATCH] MODULE_MAGIC_COOKIE field for module structure References: <19981106125801.A17402@engelschall.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.93.2i In-Reply-To: <19981106125801.A17402@engelschall.com>; from Ralf S. Engelschall on Fri, Nov 06, 1998 at 12:58:01PM +0100 X-Operating-System: SINIX-D 5.41 C1001 X-Organization: Siemens AG (Muenchen, W.Germany) X-Phone: +49-89-636-46021 X-Disclaimer: THE COMMENTS CONTAINED IN THIS MESSAGE REFLECT THE VIEWS OF THE WRITER AND ARE NOT NECESSARILY THE VIEWS OF SIEMENS AG X-No-Junk-Mail: I do not want to get *any* junk mail. Sender: new-httpd-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org On Fri, Nov 06, 1998 at 12:58:01PM +0100, Ralf S. Engelschall wrote: > --- ap_mmn.h 1998/10/03 18:46:01 1.9 > +++ ap_mmn.h 1998/11/06 11:45:53 > @@ -181,7 +181,10 @@ > * (for implementing better error reporting). > * 19980906 (1.3.2-dev) - added ap_md5_binary() > * 19980917 (1.3.2-dev) - bs2000: changed os_set_authfile() to os_set_account() > + * 19981005 (1.3.4-dev) - Added MODULE_MAGIC_COOKIE to identify module structures > */ You missed Roy's recent WebDAV MMN bump. > +#define MODULE_MAGIC_COOKIE 0x4150414348453133 /* "APACHE13" */ Can I have some lower case letters here? Or even better: a String? (That would allow the name to be readable even on EBCDIC platforms). FWIW, it doesn't have to be a zero-delimited string if the length of eight matters. Just a thought. OTOH, comparing a long is easier. BTW, what do you expect the size of a long to be? On most of my machines, it's still a 4-byte qualtity, only long long (if supported) is 8 bytes. That would seriously degrade the "understandability" of your patch... Even with an appended "UL" #define MODULE_MAGIC_COOKIE 0x4150414348453133UL /* "APACHE13" */ I still get /tmp/x.c 4: [warning]: Integer too big (and truncation to 4 bytes). Other than that, I'm +1 on the concept. Martin -- | Siemens Information and Phone: +49-89-636-46021 | Communication Products FAX: +49-89-636-47816 | 81730 Munich, Germany