httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <martin.krae...@mch.sni.de>
Subject Re: [PATCH] MODULE_MAGIC_COOKIE field for module structure
Date Sun, 08 Nov 1998 19:10:39 GMT
On Fri, Nov 06, 1998 at 12:58:01PM +0100, Ralf S. Engelschall wrote:
> --- ap_mmn.h	1998/10/03 18:46:01	1.9
> +++ ap_mmn.h	1998/11/06 11:45:53
> @@ -181,7 +181,10 @@
>   *                        (for implementing better error reporting).
>   * 19980906 (1.3.2-dev) - added ap_md5_binary()
>   * 19980917 (1.3.2-dev) - bs2000: changed os_set_authfile() to os_set_account()
> + * 19981005 (1.3.4-dev) - Added MODULE_MAGIC_COOKIE to identify module structures
>   */

You missed Roy's recent WebDAV MMN bump.

> +#define MODULE_MAGIC_COOKIE 0x4150414348453133 /* "APACHE13" */

Can I have some lower case letters here? Or even better: a String?
(That would allow the name to be readable even on EBCDIC platforms).
FWIW, it doesn't have to be a zero-delimited string if the length of
eight matters. Just a thought. OTOH, comparing a long is easier.

BTW, what do you expect the size of a long to be? On most of my
machines, it's still a 4-byte qualtity, only long long (if
supported) is 8 bytes. That would seriously degrade the
"understandability" of your patch...
Even with an appended "UL"
#define MODULE_MAGIC_COOKIE 0x4150414348453133UL /* "APACHE13" */
I still get
/tmp/x.c      4: [warning]:   Integer too big
(and truncation to 4 bytes).

Other than that, I'm +1 on the concept.

    Martin
-- 
<Martin.Kraemer@Mch.SNI.De>      |        Siemens Information and
Phone: +49-89-636-46021          |        Communication  Products
FAX:   +49-89-636-47816          |        81730  Munich,  Germany

Mime
View raw message