httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ralf S. Engelschall" <...@engelschall.com>
Subject Re: cvs commit: apache-1.3/src/main alloc.c
Date Sat, 07 Nov 1998 14:33:14 GMT

In article <Pine.LNX.3.96dg4.981106075618.20326P-100000@twinlark.arctic.org> you wrote:


> On 6 Nov 1998 rse@hyperreal.org wrote:

>>   Fix internal handling of registered cleanups in alloc.c by making sure that
>>   NULL-specified callback functions (we don't do this in the official set of
>>   modules, but third-party modules do) for ap_register_cleanup() always mean the
>>   dummy ap_null_cleanup() so we don't dump core later when running the cleanups.

> If third party modules do this, they are broken.  The API requires the
> parameters to be non-null.  This is not a new feature of 1.3, it's even
> there in the 1.2 code, it's been there forever.  There's essentially no
> reason we should expend the extra comparison and branch in the code just
> to accomodate this. 

Ok, because we define the API this way I've backed out the change.
Thanks for disagreeing.
                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com

Mime
View raw message