httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ken Parzygnat" <kp...@raleigh.ibm.com>
Subject RE: [PATCH] RE: Canonical filename overhaul
Date Wed, 04 Nov 1998 16:27:23 GMT
> > 
> > BTW, wouldn't it make more sense to return NULL if szFile is NULL?
> 
> Probably.  I've updated this too.  I was originally thinking that we
> needed to return some string.  This sort of falls under your next
> comment.
> 
After looking at this a little more, there are places in the core code that
don't check for a NULL return from ap_os_canonical_filename.  Therefore,
it probably is safer to return an empty string for now.

> > 
> > Double-BTW, there isn't a defined way for ap_os_canonical_filename to
> > return an error. Do we want one?
> > 
> I'm back and forth on this.  In one respect it would be nice to have error
> codes to indicate things like NULL parameters and filenames that are way
> too long.  But on the other hand, I think that ap_os_canonical_filename
> should make the best attempt it can at returning something since we don't
> want to make too many assumptions about the input.  I'm really not sold
> either way.
If we decide to do this, this should probably go in on its own patch since
we will have to change core code to look for error codes. 

So, anyone against committing this patch?  Any +1's?


- - - - - - - - - - - - - - - - - -
Ken Parzygnat
email: kparz@raleigh.ibm.com 
 

Mime
View raw message