httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marc Slemko <ma...@worldgate.com>
Subject Re: [PATCH] RE: Canonical filename overhaul
Date Sun, 01 Nov 1998 07:57:42 GMT
On Mon, 19 Oct 1998, Ken Parzygnat wrote:

> Ok, here's the patch for you to play with.  This patch is what
> was previously discussed with one addition.  I heard through
> the grapevine (credit Marc) that one problem was related to 
> use of alias names (the loveable "blah~1" type names).  Therefore,
> I had another piece of code up my sleeve to address another problem,
> but I'm putting it on the table now because it will solve this problem.

This doesn't want to apply for me; the util_win32.c chunks fail
completely.  

Could you either see if that may be something on your end or just send the
whole util_win32.c file?

A few notes:

Get rid of the ap_assert()s.  There is no need for them and it is bad 
coding practice to use them for "normal" error conditions.  Yea, I 
know, they are a carryover from the existing code but it is broken.

Are you sure you want to return "" if the arg is too long for
the buffer in ap_os_systemcase_filename?  

Other than that, the concept looks reasonable and if it actually works
all the better...  I can't say I fully understand all the issues on 
Win32 since it is such a pain, but...  I just wish there were some 
documented way to compare file paths on Win32.  I'm sure there are
more magic cases that we don't know about.




Mime
View raw message