httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Behlendorf <br...@hyperreal.org>
Subject Re: [PATCH] TPF util_uri.c
Date Tue, 13 Oct 1998 19:27:48 GMT

This is a comment that applies to this patch and other patches.  It's been
generally agreed 'round these parts that type casts hide bugs, and thus
should be avoided.  It's also been generally agreed that OS-specific
sections should be kept out of the core code, to help keep it simpler.  So
for example, your changes to GuessOS and ap_config.h are right; changes
like the below, there should be a better way.

>+ #ifdef TPF
>+     struct hostent *hp = gethostbyname((char *)hostname);
>+ #else
>      struct hostent *hp = gethostbyname(hostname);
>+ #endif /* TPF */

Another example, the below from your util_script.c changes:

>+ #elif defined(TPF)
>+     ap_log_error(APLOG_MARK, APLOG_ERR, r->server,
>+                   "call_exec function not allowed on TPF");
>+     return (pid);

Seems like it'd be better to have a define #NO_CALL_EXEC or something,
which gets set appropriately in ap_config.h's TPF section.  

	Brian


--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
Where will YOU be Oct 14-16?                   |     brian@apache.org
ApacheCon '98!   http://www.apachecon.com/     |  brian@hyperreal.org


Mime
View raw message