httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: cvs commit: apache-1.3/src/modules/standard mod_status.c
Date Fri, 30 Oct 1998 17:53:12 GMT
Jim Jagielski wrote:
> 
> jim@hyperreal.org wrote:
> > 
> >   --- CHANGES	1998/10/27 10:20:00	1.1125
> >   +++ CHANGES	1998/10/28 13:02:35	1.1126
> >   @@ -1,5 +1,10 @@
> >    Changes with Apache 1.3.4
> >    
> >   +  *) Add the actual server_rec structure of the specific Vhost to the
> >   +     scoreboard file and avoid a string copy (as well as allow some
> >   +     further future enhancements). [Harrie Hazewinkel
> >   +     <harrie.hazewinkel@jrc.it>]
> >   +
> >        char request[64];		/* We just want an idea... */
> >   -    char vhost[32];		/* What virtual host is being accessed? */
> >   +    server_rec *vhostrec;	/* What virtual host is being accessed? */
> 
> I was thinking, couldn't we do the same for 'request' as well? Simply point
> ss->request to r->the_request? This would get rid of another string copy?
> Can't do this with 'client' but request seems right.
> 

Forget this... In fact, I think we need to back out the above. From what I
can see, once the child dies, current_con goes away and thus the
pointer for vhostrec is no longer valid, and so the data pointed
to by r->server is garbage, or at least we have no guarantee of it's
validity.

Comments??

-- 
===========================================================================
   Jim Jagielski   |||   jim@jaguNET.com   |||   http://www.jaguNET.com/
            "That's no ordinary rabbit... that's the most foul,
            cruel and bad-tempered rodent you ever laid eyes on"

Mime
View raw message