httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ras...@lerdorf.on.ca (Rasmus Lerdorf)
Subject ap_md5() function is rather useless
Date Sat, 05 Sep 1998 04:03:51 GMT
The ap_md5() function is defined as:

API_EXPORT(char *) ap_md5(pool *p, unsigned char *string)

and it does a:

    ap_MD5Update(&my_md5, string, strlen((const char *) string));

To put it politely, this sucks.  Makes it useless for binary data.  It
needs to have a string length argument added to it which is then passed to
ap_MD5Update().  

Any objections to me fixing this?  How many modules do you think I will
break?

-Rasmus


Mime
View raw message