httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marc Slemko <ma...@worldgate.com>
Subject Re: cvs commit: apache-1.3/src/modules/standard mod_speling.c
Date Wed, 23 Sep 1998 22:47:32 GMT
I'm a bit confused; why should modules have to do anything special to keep
some obscene thing from taking over their output?  Just because something
logs something to the error log and uses one of Apache's output forms
doesn't mean what they log should be sent to the client!

I also didn't notice that this sort of thing is now sent to the client by
default.  Is there even a way to disable it?  That is a bad thing to
just start doing all the time from a security viewpoint.

On 23 Sep 1998 manoj@hyperreal.org wrote:

> manoj       98/09/23 15:42:06
> 
>   Modified:    src      CHANGES
>                src/modules/standard mod_speling.c
>   Log:
>   PR: 3052
>   Reviewed by:	Ken Coar <coar@apache.org>
>   
>   Fix mod_speling's handling of multiple matched URLs.
>   
>   Revision  Changes    Path
>   1.1073    +3 -0      apache-1.3/src/CHANGES
>   
>   Index: CHANGES
>   ===================================================================
>   RCS file: /export/home/cvs/apache-1.3/src/CHANGES,v
>   retrieving revision 1.1072
>   retrieving revision 1.1073
>   diff -u -r1.1072 -r1.1073
>   --- CHANGES	1998/09/22 09:19:51	1.1072
>   +++ CHANGES	1998/09/23 22:42:03	1.1073
>   @@ -1,5 +1,8 @@
>    Changes with Apache 1.3.3
>    
>   +  *) Fix mod_speling's handling of multiple matched URLs.
>   +     [Manoj Kasichainula]
>   +
>      *) Correct comment in mod_log_config.c about its internals.
>         [Elf Sternberg <elf@halcyon.com>]
>    
>   
>   
>   
>   1.27      +4 -0      apache-1.3/src/modules/standard/mod_speling.c
>   
>   Index: mod_speling.c
>   ===================================================================
>   RCS file: /export/home/cvs/apache-1.3/src/modules/standard/mod_speling.c,v
>   retrieving revision 1.26
>   retrieving revision 1.27
>   diff -u -r1.26 -r1.27
>   --- mod_speling.c	1998/09/19 12:16:38	1.26
>   +++ mod_speling.c	1998/09/23 22:42:05	1.27
>   @@ -506,6 +506,10 @@
>    			     : "Spelling fix: %s: %d candidates",
>    			 r->uri, candidates->nelts, ref);
>    
>   +            /* The log entry above will be sent to the client instead of the
>   +             * page we've constructed unless we take it out of error-notes */
>   +            ap_table_unset(r->notes, "error-notes");
>   +
>                return HTTP_MULTIPLE_CHOICES;
>            }
>        }
>   
>   
>   
> 


Mime
View raw message