httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <martin.krae...@mch.sni.de>
Subject Re: cvs commit: apache-1.3/src/support apachectl
Date Fri, 11 Sep 1998 15:45:56 GMT
On Fri, Sep 11, 1998 at 08:16:10AM -0600, Charles Randall wrote:
> + 	      if ( pidfile != NULL ) {
> + 		fprintf(stderr, "cleanup_pidfile(%s) - pid=%d\n",
> + 			pidfile, getpid());

------->>       ^^^^^^^^^^^^^^^
This could be changed to use ap_log_error(). I think it'd be cleaner.

> + 		cleanup_pidfile(pidfile);
> + 	      }
> + 	    }
> + 
>   	    ap_log_error(APLOG_MARK, APLOG_NOERRNO|APLOG_NOTICE, server_conf,
>   			"httpd: caught SIGTERM, shutting down");
>   	    clean_parent_exit(0);
>   	}

For the rest, +1 (untested).

    Martin
-- 
| S I E M E N S |  <Martin.Kraemer@mch.sni.de>  |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request

Mime
View raw message