httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <martin.krae...@mch.sni.de>
Subject Re: ap_md5() function is rather useless
Date Sun, 06 Sep 1998 16:09:28 GMT
On Sat, Sep 05, 1998 at 04:55:28PM +0100, Ben Laurie wrote:
> Rasmus Lerdorf wrote:
> > But it is a trivial change to make the current one binary safe.
> 
> Sure, it makes sense, but the way to do it is this:
> 
> API_EXPORT(char *) ap_md5_binary(pool *p, unsigned char *buf,int len)
> 	{
> 	...
> 	}
> 
> API_EXPORT(char *) ap_md5(pool *p, unsigned char *string)
> 	{
> 	return ap_md5_binary(p,string,strlen(string));
> 	}

+1 for this change. That even better documents that ap_md5 was never
meant to be called for binary data.

    Martin
-- 
| S I E M E N S |  <Martin.Kraemer@mch.sni.de>  |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request

Mime
View raw message