httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: cvs commit: apache-1.3/src/main http_main.c
Date Tue, 11 Aug 1998 21:40:41 GMT
It wasn't an order... it was me reviewing a commit and saying "I don't
like that... here's why" which is exactly what you're supposed to do when
reviewing a commit.  Sorry my email manner can be terse at times.

I guess you missed ed's message yesterday, I forget what the Subject was. 

Dean

On Tue, 11 Aug 1998, Jim Jagielski wrote:

> Oh yeah... maybe it might be nicer to say something like "Jim, why not
> modify mod_status to not display the fields instead. It's more
> efficient" instead of the below. It sure sounds like an order from
> on high :)
> 
> Jim Jagielski wrote:
> > 
> > Where was Ed's suggestion suggested? Maybe I will.
> > 
> > Dean Gaudet wrote:
> > > 
> > > On 11 Aug 1998 jim@hyperreal.org wrote:
> > > 
> > > >   +	} else if (status == SERVER_BUSY_READ) {
> > > >   +	    /*
> > > >   +	     * When reading a "new" request, we don't want to show the old

> > > >   +	     * info since that's confusing... so NULL it out quickly since
> > > >   +	     * we want to hurry up and read the request.
> > > >   +	     */
> > > >   +	    *ss->vhost = *ss->request = *ss->client = '\0';
> > > 
> > > -1.  Please follow Ed's suggestion and modify mod_status to not display
> > > these fields, it's more efficient. 
> > > 
> > > Dean
> > > 
> > > 
> > 
> > 
> > -- 
> > ===========================================================================
> >    Jim Jagielski   |||   jim@jaguNET.com   |||   http://www.jaguNET.com/
> >             "That's no ordinary rabbit... that's the most foul,
> >             cruel and bad-tempered rodent you ever laid eyes on"
> > 
> 
> 
> -- 
> ===========================================================================
>    Jim Jagielski   |||   jim@jaguNET.com   |||   http://www.jaguNET.com/
>             "That's no ordinary rabbit... that's the most foul,
>             cruel and bad-tempered rodent you ever laid eyes on"
> 


Mime
View raw message