httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: cvs commit: apache-1.3/src/main http_protocol.c
Date Mon, 10 Aug 1998 05:35:30 GMT


On Sun, 9 Aug 1998, Jim Jagielski wrote:

> dgaudet@hyperreal.org wrote:
> > 
> > dgaudet     98/08/09 09:57:29
> > 
> >   Modified:    src/include httpd.h
> >                src/main http_protocol.c
> >   Log:
> >   Include everything in the limits, rather than having to remember to
> >   add 2 to some of them... which leads to off-by-1 errors like one I just
> >   committed.  (I don't understand what the + 2 was all about.  It doesn't
> >   fit \r\n\0...)
> 
> Hmmm... This would mean that people would need to recall to add 2 to
> their own config-time values... :/

No.  The directive can add +2.  At least then the knowledge of this +2 is
more centralized. 

Dean

> 
> >        tmp = ap_make_sub_pool(r->pool);
> >   -    l = ap_palloc(tmp, r->server->limit_req_line + 2);
> >   +    l = ap_palloc(tmp, r->server->limit_req_line);
> >        ll = l;
> >    
> 
> -- 
> ===========================================================================
>    Jim Jagielski   |||   jim@jaguNET.com   |||   http://www.jaguNET.com/
>             "That's no ordinary rabbit... that's the most foul,
>             cruel and bad-tempered rodent you ever laid eyes on"
> 


Mime
View raw message