httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: cvs commit: apache-1.3/src/main http_config.c http_protocol.
Date Mon, 10 Aug 1998 05:33:30 GMT


On Sun, 9 Aug 1998, Roy T. Fielding wrote:

> Just my luck that I don't look up the one thing that isn't portable.
> 
> BTW, I was serious when I said I tested it extensively.  I want people
> to go ahead and commit FIXES to what I committed, but for chrissakes
> test them first.  The current code will not work, since that sizeof
> calculation with the +2 was important (and is documented in getline).
> One is the terminating null and the other is the newline \n, which
> is a boundary condition created by buff.c.  The choice of 8190 as the
> default is for (obvious) performance reasons, but that doesn't affect
> the correctness.  Now it is just screwed because Dean changed it without
> understanding it, which quite frankly should never be done unless there
> is a damn good reason to rush things.

I understood the code, and I did a simple translation.  I moved +2 into
the constant, where it belongs. 

Look at things like PATH_MAX, they include the trailing \0.  It's plain
stupid to expect people to remember whether to +1 or +2 when using buffer
constants. 

Dean

> 
> I suggest we ditch the first three as configurable options and I'll
> restore the buffer calculations.  The last one (body size) is not
> used for a buffer anyway, so can be configurable.
> 
> ....Roy
> 


Mime
View raw message