httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rodent of Unusual Size <Ken.C...@Golux.Com>
Subject Re: [PATCH] PR#1644: mod_rewrite and Vary
Date Sun, 12 Jul 1998 19:48:06 GMT
Ralf S. Engelschall wrote:
> 
> Looks good to me. Just one question: Is an initializing ap_table_unset
> for VARY_KEY not needed somewhere? Can we safely assume we start with
> an empty VARY_KEY table entry? Beside this it looks fine for me even
> I've not tested it in real life, so +1.

Good point.  Rather than an additional call that would always be
made up front, I've added an unset when the result is copied into
r->headers_out.  That will only be called if there's actually
something in the table.

#ken	P-)}

Ken Coar                    <http://Web.Golux.Com/coar/>
Apache Group member         <http://www.apache.org/>
"Apache Server for Dummies" <http://Web.Golux.Com/coar/ASFD/>

Mime
View raw message