httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ralf S. Engelschall" <...@engelschall.com>
Subject Re: [PATCH] PR#1644: mod_rewrite and Vary
Date Sun, 12 Jul 1998 08:14:43 GMT

In article <35A809E7.EFD79C63@Golux.Com> you wrote:
> Rodent of Unusual Size wrote:
>> 
>> Aw, nuts.  This is broken; any condition failure will wipe out
>> the record of any previous successes.  Take 2 coming up..

> Here's take 2.

> It's still only a partial fix.  We don't handle setting the Vary
> field very well; for instance, Vary isn't sent back if the
> rewrite resulted in a cachable redirect.  So I'm not sure this
> is even worth it.

> Opinions?

Looks good to me. Just one question: Is an initializing ap_table_unset for
VARY_KEY not needed somewhere? Can we safely assume we start with an empty
VARY_KEY table entry? Beside this it looks fine for me even I've not tested it
in real life, so +1.
                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com

Mime
View raw message