httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] Fixing ap_escape_quotes
Date Sat, 20 Jun 1998 01:44:50 GMT


On Fri, 19 Jun 1998, Alexei Kosut wrote:

> IIRC, the NULL pool has special meaning when given to the pool code, so
> that might be a bad idea.

I curse the meaning it has... make_sub_pool will make a pool that has no
parent... which in every case I've seen it used has lead to a memory leak
on restart.  I removed this "feature" in apache-nspr.

> What's the big deal about having code use pools? It's still "httpd
> neutral", it just needs alloc.c and alloc.h. Which are nearly entirely
> independent of Apache. Just make the pool stuff part of libap. That's
> probably a good idea anyway. 

Yup we all probably agree on that... the question becomes: do we do it in
1.3.x or do we do it in 2.0?  I wouldn't mind seeing it in apache-nspr... 
I wouldn't mind seeing apache-nspr as the basis for 2.0 work.  I haven't
heard any complaints about that concept... or maybe I'm just ignoring them
:)

If enough folks agree that apache-nspr is the basis for 2.0 work then I
could commit it and the fun can start.  A game plan would be nice though
:)

> Or use alloca. But I think we had that discussion already... ;)

doesn't work -- you need to pass the pointer back, alloca memory is
destroyed on function exit.

Dean


Mime
View raw message