httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexei Kosut <ako...@leland.Stanford.EDU>
Subject [PATCH] missing code from conditional matching
Date Wed, 01 Jul 1998 05:51:13 GMT
It has come to my attention that late in 1996, Roy committed a patch that
revamped the Apache code to check If-Modified-Since, If-Unmodified-Since,
If-Etag, etc... In doing so, he seems to have inadvertantly removed a line
of code that I believe is absolutely essential to Apache.

Frankly, I'm amazed that we've been able to ship the server for a year and
a half without this integral peice. Here is a patch to fix it. I believe
it should be committed as soon as possible, definitely before 1.3.1. It
may even warrant a seperate announcement.

Index: main/http_protocol.c
===================================================================
RCS file: /export/home/cvs/apache-1.3/src/main/http_protocol.c,v
retrieving revision 1.221
diff -u -r1.221 http_protocol.c
--- http_protocol.c	1998/06/27 18:09:29	1.221
+++ http_protocol.c	1998/07/01 05:45:28
@@ -388,6 +388,8 @@
      * However, not all documents are guaranteed to *have* ETags, and some
      * might have Last-Modified values w/o ETags, so this gets a little
      * complicated.
+     *
+     * Roy owes Rob beer.
      */
 
     if (!is_HTTP_SUCCESS(r->status) || r->no_local_copy) {

-- Alexei Kosut <akosut@stanford.edu> <http://www.stanford.edu/~akosut/>
   Stanford University, Class of 2001 * Apache <http://www.apache.org> *


Mime
View raw message