httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexei Kosut <ako...@leland.Stanford.EDU>
Subject Re: [PATCH] Fixing ap_escape_quotes
Date Fri, 19 Jun 1998 18:56:46 GMT
On Fri, 19 Jun 1998, Marc Slemko wrote:

> On Thu, 18 Jun 1998, Rodent of Unusual Size wrote:
> > I'd like to get the attached patch (or a version of it) into 1.3.1.
> > The main thing it does is make libap httpd-neutral again, so other
> > things (like stuff in src/support) can use libap routines without
> > dragging in a lot of httpd-specific crud.  I'd just commit this,
> > but it changes MMN because it alters the ap_escape_quotes()
> > semantics.
> One way around this would be to just use malloc() if a NULL pool
> is passed in.  This could be applied more generally to allow for 
> use of functions where a pool isn't available in some bastard 
> situation.

IIRC, the NULL pool has special meaning when given to the pool code, so
that might be a bad idea.

What's the big deal about having code use pools? It's still "httpd
neutral", it just needs alloc.c and alloc.h. Which are nearly entirely
independent of Apache. Just make the pool stuff part of libap. That's
probably a good idea anyway. 

Or use alloca. But I think we had that discussion already... ;)

-- Alexei Kosut <> <>
   Stanford University, Class of 2001 * Apache <> *

View raw message