httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dirk-Willem van Gulik <dirk.vangu...@jrc.it>
Subject Re: [PATCH] Two small mistakes in the release of Apache 1.3
Date Wed, 10 Jun 1998 07:37:11 GMT


On Wed, 10 Jun 1998, Kristian K. Nielsen wrote:

> This patch fixes two small bugs in the Apache 1.3.0 sourcecode:

> 2. Another small mistake appears in mod_usertrack, where the generation
>    of the unique cookie happens. mod_usertrack simply forget to double
>    the remote servername before it truncates it, therefore only a bit
>    of the remote servername is available the rest of the server process,
>    this by example means that the remove servername would appear wrong
>    in logfiles and thereby confuse logsystems even instead of helping
>    them.

Ah. This might solve PR 2190 which I tried to track down the other day.

Dw

> +++ apache_1.3.0fix/src/modules/standard/mod_usertrack.c Tue Jun  9 18:34:14
> 1998
> @@ -138,8 +138,8 @@
>      char cookiebuf[1024];
>      char *new_cookie;
>      char *dot;
> -    const char *rname = ap_get_remote_host(r->connection,
> r->per_dir_config,
> -     REMOTE_NAME);
> +    const char *rname =
> ap_pstrdup(r->pool,ap_get_remote_host(r->connection, r->per_dir_config,
> +     REMOTE_NAME));
> 
>      if ((dot = strchr(rname, '.')))
>          *dot = '\0';            /* First bit of hostname */
> 
> 
> 


Mime
View raw message