httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marc Slemko <ma...@worldgate.com>
Subject Re: cvs commit: apache-1.3/src/modules/standard mod_autoindex.c
Date Fri, 19 Jun 1998 17:08:12 GMT
Surely we have a better way to do this than adding an ifdef and doing a
case insensitive compare on win32 only.

Don't we have canonicalization routines that can be used for this?

On 19 Jun 1998 coar@hyperreal.org wrote:

> coar        98/06/19 06:31:31
> 
>   Modified:    src      CHANGES
>                src/modules/standard mod_autoindex.c
>   Log:
>   	IndexIgnore was looking for an exact match of the filename against
>   	the pattern, even though on Win32 README.html, Readme.html, and
>   	readme.html are all the same file.
>   
>   PR:		2455
>   
>   Revision  Changes    Path
>   1.926     +3 -0      apache-1.3/src/CHANGES
>   
>   Index: CHANGES
>   ===================================================================
>   RCS file: /export/home/cvs/apache-1.3/src/CHANGES,v
>   retrieving revision 1.925
>   retrieving revision 1.926
>   diff -u -r1.925 -r1.926
>   --- CHANGES	1998/06/17 13:33:59	1.925
>   +++ CHANGES	1998/06/19 13:31:28	1.926
>   @@ -1,5 +1,8 @@
>    Changes with Apache 1.3.1
>    
>   +  *) IndexIgnore should be case-blind on Win32 (and any other case-aware
>   +     but case-insensitive platforms).  [Ken Coar] PR#2455
>   +
>      *) Enable DSO support for OpenBSD in general, not only for 2.x, because it
>         also works for OpenBSD 1.x. [Ralf S. Engelschall]
>    
>   
>   
>   
>   1.83      +10 -0     apache-1.3/src/modules/standard/mod_autoindex.c
>   
>   Index: mod_autoindex.c
>   ===================================================================
>   RCS file: /export/home/cvs/apache-1.3/src/modules/standard/mod_autoindex.c,v
>   retrieving revision 1.82
>   retrieving revision 1.83
>   diff -u -r1.82 -r1.83
>   --- mod_autoindex.c	1998/06/16 03:40:13	1.82
>   +++ mod_autoindex.c	1998/06/19 13:31:30	1.83
>   @@ -534,10 +534,20 @@
>    	    ap++;
>    	}
>    
>   +#ifndef WIN32
>    	if (!ap_strcmp_match(path, p->apply_path)
>    	    && !ap_strcmp_match(tt, ap)) {
>    	    return 1;
>    	}
>   +#else  /* !WIN32 */
>   +	/*
>   +	 * On Win32, the match must be case-blind.
>   +	 */
>   +	if (!ap_strcasecmp_match(path, p->apply_path)
>   +	    && !ap_strcasecmp_match(tt, ap)) {
>   +	    return 1;
>   +	}
>   +#endif /* !WIN32 */
>        }
>        return 0;
>    }
>   
>   
>   
> 


Mime
View raw message