httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Stoddard <wgsto...@us.ibm.com>
Subject Re: [PATCH] Re: Filenames containing whitespace characters
Date Thu, 25 Jun 1998 16:08:14 GMT
Ben Laurie wrote:

> Bill Stoddard wrote:
> >
> > This patch should fix the reported problem...
>
> Does it the code already deal with the quoting required in the
> arguments?
>
> Cheers,
>
> Ben.

The code does not add any quotes to the argument list and I don't think it should, if I understand
your question.  This patch constructs a quoted string from r->filename and uses that string
to build
the CreateProcess command line. The only other exposure I see is if someone creates a shebang
line
with spaces, E.g., #!/Program Files/perl/perl.exe. That's going to fail. (#!"/Program
Files/perl/perl.exe" should work though...)

Am I missing something?

Bill Stoddard
wgstodda@us.ibm.com


Mime
View raw message