httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: [PATCH] NT CGI - Fetch interpreter from registry and oth
Date Sun, 14 Jun 1998 11:14:19 GMT
W G Stoddard wrote:
> 
> I did take some liberties in getting rid of tabs. Other than that, most
> everything else (or the gratuitous ilk :-) was directed at making the code more
> readable!

Readability patches should not be combined with functionality patches,
because they hamper code review. By all means submit separate
readability patches, but do remember that they should conmform to the
style guide.

> If the registery query fails to find the interpreter, the code still does the
> shebang peek as a last resort.

I think we should be able to configure the order. The example of
multiple Perl versions is a good one. Also, people may not want to have
to mess with the registry to get appropriate interpreters to run.

> I was really tempted to eliminate the peek code
> altogether (thinking like a windows weenie) then (thinking like a unix hack)
> decided not.  Not too crazy about that 2048 buffer on the stack...

Any particular reason?

Cheers,

Ben.

-- 
Ben Laurie            |Phone: +44 (181) 735 0686| Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org/
and Technical Director|Email: ben@algroup.co.uk |
A.L. Digital Ltd,     |Apache-SSL author     http://www.apache-ssl.org/
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache/

WE'RE RECRUITING! http://www.aldigital.co.uk/recruit/

Mime
View raw message