httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ralf S. Engelschall" <...@engelschall.com>
Subject Re: cvs commit: apache-1.3/src/os/win32 mod_isapi.c
Date Sun, 14 Jun 1998 09:01:07 GMT

In article <19980613152319.26869.qmail@hyperreal.org> you wrote:
> ben         98/06/13 08:23:19

>[...]
>   Constify tables.
>[...]
>   +  *) Make table elements const. This may prevent obscure errors. [Ben Laurie]
>[...]

Hmmm.... still haven't looked at the recent changes in detail but after
merging in these changes I get a lot of new warnings while in the last weeks
all was quiet:

--------------
http_protocol.c: In function `ap_set_byterange':
http_protocol.c:182: warning: passing arg 4 of `internal_byterange' from
incompatible pointer type

mod_log_config.c:468: warning: initialization from incompatible pointer type
mod_log_config.c:471: warning: initialization from incompatible pointer type
mod_log_config.c:474: warning: initialization from incompatible pointer type
mod_log_config.c:477: warning: initialization from incompatible pointer type

mod_log_agent.c: In function `agent_log_transaction':
mod_log_agent.c:158: warning: assignment discards `const' from pointer target
type

mod_log_referer.c: In function `referer_log_transaction':
mod_log_referer.c:176: warning: assignment discards `const' from pointer
target type

mod_mime_magic.c: In function `magic_rsl_to_request':
mod_mime_magic.c:819: warning: passing arg 1 of `ap_content_type_tolower'
discards `const' from pointer target type
mod_mime_magic.c:826: warning: passing arg 1 of `ap_str_tolower' discards
`const' from pointer target type

mod_mime.c: In function `find_ct':
mod_mime.c:283: warning: assignment from incompatible pointer type

mod_negotiation.c: In function `do_languages_line':
mod_negotiation.c:442: warning: passing arg 2 of `ap_get_token' from
incompatible pointer type
mod_negotiation.c: In function `read_type_map':
mod_negotiation.c:736: warning: passing arg 2 of `ap_get_token' from
incompatible pointer type
mod_negotiation.c:752: warning: passing arg 2 of `ap_get_token' from
incompatible pointer type
mod_negotiation.c:755: warning: passing arg 2 of `ap_get_token' from
incompatible pointer type

mod_unique_id.c: In function `gen_unique_id':
mod_unique_id.c:331: warning: assignment discards `const' from pointer target
type

proxy_cache.c: In function `help_proxy_garbage_coll':
proxy_cache.c:334: warning: long int format, different type arg (arg 6)
proxy_cache.c:365: warning: long int format, different type arg (arg 6)

mod_example.c: In function `trace_add':
mod_example.c:347: warning: assignment discards `const' from pointer target
type
--------------

He can get it yourself with this:

$ CFLAGS="-pipe -O0 -Wall -Wshadow -Wpointer-arith -Wcast-align
  -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -Winline" \
  exec ./configure --prefix=/tmp/apache 

Perhaps you should again have a look at the side-effects these
changes caused, Ben. Thanks.
                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com

Mime
View raw message