httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian K. Nielsen" <apa...@ctav.com>
Subject [PATCH] Two small mistakes in the release of Apache 1.3
Date Wed, 10 Jun 1998 02:17:45 GMT
This patch fixes two small bugs in the Apache 1.3.0 sourcecode:

1. The time that Randy Terbush decided to change the default group from
   "nouser" to "nogroup", he forgot to change it one time in conf.h.

2. Another small mistake appears in mod_usertrack, where the generation
   of the unique cookie happens. mod_usertrack simply forget to double
   the remote servername before it truncates it, therefore only a bit
   of the remote servername is available the rest of the server process,
   this by example means that the remove servername would appear wrong
   in logfiles and thereby confuse logsystems even instead of helping
   them.

Enjoy!

Greetings
Kristian K. Nielsen,
jkkn@ctav.com


--- apache_1.3.0/src/CHANGES Sat May 30 12:15:37 1998
+++ apache_1.3.0fix/src/CHANGES Tue Jun  9 18:41:57 1998
@@ -1,3 +1,12 @@
+Changes with Apache 1.3
+
+  *) Completed the default group change to "nogroup" instead of "nobody"
+     [Kristian Kraemmer Nielsen <jkkn@ctav.com>]
+
+  *) Fixed a small bug in mod_usertrack that caused the remote hostname
+     to be truncated in the rest of the server process, e.x. hostname would
+     appear wrong in logfiles. [Kristian Kraemmer Nielsen <jkkn@ctav.com>]
+
 Changes with Apache 1.3b8

   *) Using a type map file as a custom error document was not possible.
--- apache_1.3.0/src/include/conf.h Thu May 28 17:15:56 1998
+++ apache_1.3.0fix/src/include/conf.h Tue Jun  9 18:17:49 1998
@@ -242,7 +242,7 @@
 #define USE_MMAP_FILES
 #define HAVE_SYSLOG 1
 #ifndef DEFAULT_GROUP
-#define DEFAULT_GROUP "nobody"
+#define DEFAULT_GROUP "nogroup"
 #endif
 #endif
 #ifndef DEFAULT_USER
--- apache_1.3.0/src/modules/standard/mod_usertrack.c Sat Apr 11 05:00:53
1998
+++ apache_1.3.0fix/src/modules/standard/mod_usertrack.c Tue Jun  9 18:34:14
1998
@@ -138,8 +138,8 @@
     char cookiebuf[1024];
     char *new_cookie;
     char *dot;
-    const char *rname = ap_get_remote_host(r->connection,
r->per_dir_config,
-     REMOTE_NAME);
+    const char *rname =
ap_pstrdup(r->pool,ap_get_remote_host(r->connection, r->per_dir_config,
+     REMOTE_NAME));

     if ((dot = strchr(rname, '.')))
         *dot = '\0';            /* First bit of hostname */



Mime
View raw message