Message-Id: <3.0.3.32.19980519162646.007c7e10@hyperreal.org>
Date: Tue, 19 May 1998 16:26:46 -0700
To: new-httpd@apache.org
From: Brian Behlendorf <brian@hyperreal.org>
Subject: piped logs
In-Reply-To: <3561F73F.3DA71E0A@algroup.co.uk>
References: <19980519191906.10826.qmail@hyperreal.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Sender: new-httpd-owner@apache.org
Precedence: bulk
Reply-To: new-httpd@apache.org

At 10:18 PM 5/19/98 +0100, Ben Laurie wrote:
>Oh yeah - BTW, the things that are doing piped logs should really use
>ap_open_piped_log, which will reduce the pain (as well as making them
>better).

Hmm - http_log itself doesn't use ap_open_piped_logs to open the ErrorLog.
Should it?

When I try and apply the same deal I did for the other modules, I get a
cast warning of reassignment - and indeed, s->error_log is defined as a
FILE * whereas ap_piped_log_write_fd returns an int.  It looks like
changing the definition of error_log from a FILE * to an int could be
problematic, since "stderr" is by C standards a FILE *.

For now I'm not going to worry about it I guess, but if anyone's inclined...

	Brian


--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
pure chewing satisfaction                                  brian@apache.org
                                                        brian@hyperreal.org