httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] PR#1031 using a type map as a custom error document
Date Tue, 26 May 1998 00:54:52 GMT


On Mon, 25 May 1998, Lars Eilebrecht wrote:

> According to Dean Gaudet:
> 
> >  Hey can you explain why you're using r->no_local_copy?  I'm confused... 
> >  Actually I think I'm just confused because r->no_local_copy appears to
> >  be true iff this expression is true:
> >  
> >      r->status != HTTP_OK && !is_initial_req(r)
> 
> I know that r->no_local_copy has a different meaning, but I used
> it as an indicator for a custom response internal redirect,
> because it is set in ap_die() before ap_internal_redirect(custom_response,r) is
> called.
> I wasn't sure if using is_initial_req(r) is a good thing, because this
> may break things when we are processing an internal redirect, but
> are not trying to build a custom response.
> But maybe I'm just missing something.

Actually I'm wrong... it's more like:

	r->status != HTTP_OK && (r->prev || it was a custom error response)

I wasn't really trying to say that is_initial_req should be used... I was just
trying to figure out what no_local_copy means.  (And I still don't really
understand it.)

> [...]
> >  ... I'd say that the correct fix is to remove the r->status test from
> >  read_type_map and push it into read_types_multi, which is the only caller
> >  that needs the security protection.  When read_type_map is called by
> >  handle_map_file() the security protection has already been taken care of.
> 
> Yes, that seems to be the best fix.

You wanna try it out?  Or should I just commit it?

Dean


Mime
View raw message