httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dean Gaudet <dgau...@arctic.org>
Subject Re: [PATCH] ap_pcfg_openfile knows about device files
Date Fri, 08 May 1998 19:09:18 GMT


On Fri, 8 May 1998, Jim Jagielski wrote:

> Dean Gaudet wrote:
> > 
> > 
> > 
> > On Fri, 8 May 1998, Jim Jagielski wrote:
> > 
> > > This patch removes the unvoted_DISALLOW_DEVICE_ACCESS wrapper so
> > > now ap_pcfg_openfile can stop opening of non-/dev/null devices.
> > > Also, as per Dean's suggestion, it now uses ap_pfopen instead of
> > > fopen. However, this required some API changes... PLEASE review
> > > and comment.
> > 
> > Hmm I was trying to remember why I said that :)  Now I remember --
> > timeouts. 
> > 
> > Technically speaking you don't need an API change.  You can create a
> > structure with the pool and FILE * in it and pass that as the void*.
> 
> It's still a change to what configfile_t looks like though... Thus, the
> API change.

No it doesn't.  configfile_t needs no change.  You need to create a new
structure, one that contains FILE * and pool *, and use it for the param
in the configfile_t structure.

It's just like how the ap_pcfg_open_custom() in http_config is passed a
special structure containing all the pieces. 

Dean


Mime
View raw message